fix(search): allow author name search in editorial dashboard for user…#12416
Open
MrRob100 wants to merge 3 commits intopkp:stable-3_4_0from
Open
fix(search): allow author name search in editorial dashboard for user…#12416MrRob100 wants to merge 3 commits intopkp:stable-3_4_0from
MrRob100 wants to merge 3 commits intopkp:stable-3_4_0from
Conversation
…s with review assignments The Collector's searchPhrase logic blocked author name search for any user with assignedTo set who also had any review_assignment row, even historically. This was overly broad for the editorial dashboard where editors need to find submissions by author name. Adds an allowAuthorSearch flag (default false, preserving existing behaviour everywhere) that PKPBackendSubmissionsHandler opts into, bypassing the reviewer restriction only for the /_submissions endpoint. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 task
Vitaliy-1
reviewed
Mar 19, 2026
Contributor
Vitaliy-1
left a comment
Vitaliy-1
left a comment
There was a problem hiding this comment.
If following the logic to allow search by authors if 1) the user has stage assignment 2) the review isn't double blind, I'd rather make correspondent changes directly to this part of the query builder:
pkp-lib/classes/submission/Collector.php
Line 470 in b752be9
e.g.,
- join stage assignments for a check
- additional
whereto checkreview_method
Contributor
Author
|
@Vitaliy-1 Thank you for the review, changes are in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This affects authors with review assignments
The Collector's searchPhrase logic blocked author name search for any user with assignedTo set who also had any review_assignment row, even historically. This was overly broad for the editorial dashboard where editors need to find submissions by author name.
Adds an allowAuthorSearch flag (default false, preserving existing behaviour everywhere) that PKPBackendSubmissionsHandler opts into, bypassing the reviewer restriction only for the /_submissions endpoint.
#12415