Rename privacy consent id on reviewer's page#12423
Open
blesildaramirez wants to merge 5 commits intopkp:mainfrom
Open
Rename privacy consent id on reviewer's page#12423blesildaramirez wants to merge 5 commits intopkp:mainfrom
blesildaramirez wants to merge 5 commits intopkp:mainfrom
Conversation
jardakotesovec
approved these changes
Mar 10, 2026
Contributor
jardakotesovec
left a comment
jardakotesovec
left a comment
There was a problem hiding this comment.
That looks promising, small suggestion.
cypress/support/commands.js
Outdated
| cy.get('button').click() | ||
| }) | ||
| cy.get('input[id="privacyConsent"]').click(); | ||
| cy.get('input[id="dataCollectionCheck"]').click(); |
Contributor
There was a problem hiding this comment.
Looks good.. just minor suggestion - if the id is problem and its used only in cypress test - we could go with name="privacyConsent" in the cypress test and basically just change id to name.
blesildaramirez
force-pushed
the
rename-privacy-consent
branch
from
a824a33 to
7ce7b44
Compare
…ng checkbox field for some browsers
blesildaramirez
force-pushed
the
rename-privacy-consent
branch
from
f791a08 to
10ffeb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.