pkp/pkp-lib#9950 Add laravel pagination support for useFetchPaginated #348
Conversation
| @@ -15,6 +15,7 @@ import {setActivePinia, createPinia} from 'pinia'; | |||
|
|
|||
| import {useFetch} from './useFetch'; | |||
| import {useModalStore} from '@/stores/modalStore'; | |||
| global.pkp = global.pkp || {}; | |||
There was a problem hiding this comment.
Was this not causing issues in previous versions of the test or is there something new with the new tests that necessitated this?
There was a problem hiding this comment.
@ewhanson yeah, we have not had ui-library unit tests running on CI - so it regressed over time..
We are adding the it here pkp/pkp-lib#9951
| @@ -16,7 +16,7 @@ | |||
| export function t(key, params) { | |||
| if ( | |||
| typeof pkp === 'undefined' || | |||
| typeof pkp.localeKeys[key] === 'undefined' | |||
| typeof pkp?.localeKeys?.[key] === 'undefined' | |||
There was a problem hiding this comment.
Was this and the other optional chaining additions causing issues previously, or was there something specific to these changes that drew your attention to this?
There was a problem hiding this comment.
It was causing issues previously.. but noticed it while working on this, when I run tests after some time.
There was a problem hiding this comment.
Figured it was something like this, but wanted to make sure I wasn't missing anything else. Thanks!
No description provided.