pkp/pkp-lib#11826 Update task template form to add "Mark as Unrestricted" & "Limit access to user groups" fields #750
+228
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
blesildaramirez
force-pushed
the
i11826
branch
from
cc141db to
ecd394f
Compare
jardakotesovec
requested changes
Dec 9, 2025
Contributor
jardakotesovec
left a comment
jardakotesovec
left a comment
There was a problem hiding this comment.
Two minor suggestions. I think it make sense to list all roles..
| let label = `${participant.fullName} ${username}`; | ||
|
|
||
| if (participant.userName === currentUser.getCurrentUserName()) { | ||
| if (participant.username === currentUser.getCurrentUserName()) { |
Contributor
There was a problem hiding this comment.
Minor thing. Even though username should be unique - checking by id feels safer.
| label, | ||
| subLabel: withSubLabel ? participant.roleName : null, | ||
| value: participant.id, | ||
| subLabel: withSubLabel ? participant.roles?.[0]?.name : null, |
Contributor
There was a problem hiding this comment.
Current discussions are listing all roles. Its not all roles of that user - but all roles that given user is assigned to the submission. I see that @Vitaliy-1 handled that nicely already on the backend.
Anyway - I think just comma separated list here would be good.
…roups field to task template form
…e payload when saving task template
blesildaramirez
force-pushed
the
i11826
branch
from
ecd394f to
02d6fe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.