prepare rama-ua for UA profiles, that can be used for UA Emulation (client-side) #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as to make room for also adding the profile types
next steps: - add unit tests - refactor rama-fp to make use of this - add storage trait in rama-fp - store data in postgres for rama-fp (@fly.io) - expose data in website - test & iterate - ship embedding profiles automatically via a script into rama-ua we'll do in a follow-up PR
next up... db.. again again
this provider will be used by the layer logic to select a UA based on the given ctx which also allows someone else to implent their own logic
can be useful so one doesn't require two layers if there is no use of the user agent outside of emulating
so far all seems to be without any bugs found so far, still good to have these tests to prevent mistakes in future
fixed bug regarding preserve UA opt-in flag, thx unit test
and make sure that we respect accept encoding value, as to make that kind of difficulty easier to handle
turns out to be different as well
unrelated from the PR but seems like I kinda got into a refactor dfrift, whoops
decompression will no longer happen in case the client req had a compatible encoding with the response content-encoding
header names => lowercase
and adapt python+js code to it
next steps: integrate PG db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do in a follow up PR: