Merge pull request #2 from placetopay-org/feature/project-is-optional

Makes the project argument Optional
placetopay-org · Apr 2, 2020 · 20a3331 · 20a3331
2 parents f1feab7 + 8874151
commit 20a3331
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/src/Console/Commands/CreateVersionFile.php b/src/Console/Commands/CreateVersionFile.php
@@ -41,7 +41,7 @@ public function handle(Factory $validator)
         VersionFile::generate([
             'sha' => $options['sha'],
             'time' => $options['time'],
-            'project' => $options['project'],
+            'project' => $options['project']?? '',
             'branch' => $options['branch'],
         ]);
 
@@ -58,7 +58,7 @@ private function validateOptions(Factory $validator)
         return $validator->make($this->options(), [
             'sha' => 'required',
             'time' => 'required',
-            'project' => 'required',
+            'project' => 'nullable',
             'branch' => 'required',
         ])->validate();
     }

diff --git a/tests/Commands/CreateVersionFileCommandTest.php b/tests/Commands/CreateVersionFileCommandTest.php
@@ -35,6 +35,26 @@ public function can_create_version_file()
         $this->assertJsonStringEqualsJsonFile(VersionFile::path(), json_encode($input));
     }
 
+    /** @test */
+    public function can_create_version_file_without_project_variable()
+    {
+        $input = [
+            'sha' => 'abcdef',
+            'time' => '20200315170330',
+            'branch' => 'master',
+            'project' => '',
+        ];
+
+        $this->artisan('app-version:create', [
+            '--sha' => $input['sha'],
+            '--time' => $input['time'],
+            '--branch' => $input['branch'],
+        ])->assertExitCode(0);
+
+        $this->assertFileExists(VersionFile::path());
+        $this->assertJsonStringEqualsJsonFile(VersionFile::path(), json_encode($input));
+    }
+
     protected function tearDown(): void
     {
         VersionFile::delete();