Fix deploy url

placetopay-org · Jun 11, 2020 · 2621ad8 · 2621ad8
1 parent 8f13ff0
commit 2621ad8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/src/Sentry/SentryApi.php b/src/Sentry/SentryApi.php
@@ -66,7 +66,7 @@ public function constructUrl(string $version = null): string
     {
         $url = self::API_URL . 'organizations/' . $this->organization . '/releases/';
         if ($version) {
-            $url .= $version . 'deploys/';
+            $url .= $version . '/deploys/';
         }
         return $url;
     }

diff --git a/tests/Mocks/FakeSentryClient.php b/tests/Mocks/FakeSentryClient.php
@@ -55,6 +55,13 @@ public function assertAuthenticationHeaderSent(string $token)
         );
     }
 
+    public function lastUrl(): string
+    {
+        Assert::assertGreaterThan(0, count($this->requests), 'There were no requests sent');
+
+        return Arr::last($this->requests)['fullUrl'];
+    }
+
     public function lastRequest(): array
     {
         return array_pop($this->requests) ?: [];

diff --git a/tests/Sentry/SentryApiTest.php b/tests/Sentry/SentryApiTest.php
@@ -35,8 +35,9 @@ public function can_create_a_sentry_deploy()
         $this->bindSentryFakeClient();
         $this->fakeClient->push('success_deploy');
 
-        $this->sentryApi()->createDeploy('asdfg2', 'local');
+        $this->sentryApi()->createDeploy('version-deployed', 'local');
 
+        $this->assertStringContainsString('releases/version-deployed/deploys/', $this->fakeClient->lastUrl());
         $this->fakeClient->assertLastRequestHas('environment', 'local');
     }
 }