Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Asynchronous input in Linux/macOS (patch ainput to reset blocking mode) #22

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: Asynchronous input in Linux/macOS (patch ainput to reset blocking mode) #22

wants to merge 2 commits into from

Conversation

plammens
Copy link
Owner

@plammens plammens commented Jun 8, 2022 •
edited
Loading

Closes #17
Closes #19

@plammens plammens changed the title Fix/ainput patch fix: Asynchronous input in Linux/macOS (patch ainput to reset blocking mode) Jun 11, 2022
@plammens plammens force-pushed the fix/ainput-patch branch 2 times, most recently from 7fd294e to ea69345 Compare June 11, 2022 17:24
@plammens
Copy link
Owner Author

Superseded by #23

@plammens plammens closed this Jun 12, 2022
@plammens
Copy link
Owner Author

plammens commented Jan 9, 2023

Might need to switch back to regular input() in pause() to avoid "enter to continue" bugs

@plammens plammens reopened this Jan 9, 2023
@plammens
fix: Clear O_NONBLOCK flag after using ainput()
a7d5746 
This is to ensure we can still use regular blocking IO such as
input() and print() after using ainput.

Fixes #17, #19
@plammens
fix: Revert back to regular input() in pause()
30839f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux: EOFError when asking input after async input MacOS: BlockingIOError
1 participant
@plammens