Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix DST change issues #94

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

miklcct
Copy link
Contributor

@miklcct miklcct commented Jul 26, 2024

The GTFS specifications specifies that the time is defined as starting from noon minus 12 hours, in order to avoid a DST change happening on a service day. Therefore, trains departing before the DST change, i.e. 02:00, should be considered part of the previous service day in GTFS:

  • A train scheduled to depart 01:05 on March changeover day will run on GMT for its whole journey, while a train scheduled to depart 02:05 will run on BST.
  • A train scheduled to depart 01:05 on October changeover day will run on BST for its whole journey, while a train scheduled to depart 02:05 will run on GMT.

This doesn't have any special handling on skipped / additional trains in the skipped / additional hour on the Night Overground services, which the handling is yet to be confirmed.

Fixes #86 .

@linusnorton linusnorton merged commit a78992b into planarnetwork:master Jul 26, 2024
4 checks passed
@miklcct miklcct deleted the late-night-fix branch September 27, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is the use of addLateNightServices?
2 participants