added support for NIP-62 Request to Vanish events #80 #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmontz
requested review from
mplorentz,
martindsq and
joshuatbrown
as code owners
I would think that would be in a separate PR, but yeah, we should do that. |
|
@joshuatbrown Based on the title of this PR, you're probably right to assume that we should make your suggested change here. I still think it would be better to separate that though. Here's a ticket for it: #1511. |
joshuatbrown
approved these changes
Sep 17, 2024
# Conflicts: # CHANGELOG.md # Nos.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
#80
Description
Adds support for authoring NIP-62 Request to Vanish events.
Note: This is only the data layer. The UI changes required for the user to make this request will be added in a subsequent PR.
No UI changes.
Initially I added a function for the new event to CurrentUser.swift, but that triggered the 500-line file lint rule. So I made an extension on CurrentUser for all the publish event functions.
This PR also adds the concept of an extension on JSONEvent that could house easier-to-use APIs for event creation. It also improves testability.