Skip to content

Comments

Refactored to use parameterized HQL APIs#23

Closed
pixeebot[bot] wants to merge 1 commit intomasterfrom
pixeebot/drip-2025-03-14-pixee-java/hql-parameterizer
Closed

Refactored to use parameterized HQL APIs#23
pixeebot[bot] wants to merge 1 commit intomasterfrom
pixeebot/drip-2025-03-14-pixee-java/hql-parameterizer

Conversation

@pixeebot
Copy link

@pixeebot pixeebot bot commented Mar 14, 2025

This change refactors Hibernate queries to be parameterized, rather than built by hand.

Without parameterization, developers must remember to escape inputs using the rules for that database. It's usually buggy, at the least -- and sometimes vulnerable.

Our changes look something like this:

- Query<User> hqlQuery = session.createQuery("select p from Person p where p.name like '" + tainted + "'");
+ Query<User> hqlQuery = session.createQuery("select p from Person p where p.name like :parameter0").setParameter(":parameter0", tainted);
More reading

🧚🤖 Powered by Pixeebot

Feedback | Community | Docs | Codemod ID: pixee:java/hql-parameterizer

@pixeebot
Copy link
Author

pixeebot bot commented Mar 22, 2025

I'm confident in this change, but I'm not a maintainer of this project. Do you see any reason not to merge it?

If this change was not helpful, or you have suggestions for improvements, please let me know!

@pixeebot
Copy link
Author

pixeebot bot commented Mar 23, 2025

Just a friendly ping to remind you about this change. If there are concerns about it, we'd love to hear about them!

@pixeebot
Copy link
Author

pixeebot bot commented Mar 29, 2025

This change may not be a priority right now, so I'll close it. If there was something I could have done better, please let me know!

You can also customize me to make sure I'm working with you in the way you want.

@pixeebot pixeebot bot closed this Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants