Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing multiple patterns through file_pattern #22

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Support passing multiple patterns through file_pattern #22

merged 1 commit into from
Aug 31, 2023

Conversation

dctrwatson
Copy link
Contributor

No description provided.

@dctrwatson dctrwatson requested a review from a team as a code owner August 31, 2023 01:19
joemiller
joemiller reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@joemiller joemiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this break existing users with the change of the input name?

@dctrwatson
Copy link
Contributor Author

Will this break existing users with the change of the input name?

I only chagned the variable name inside the script. The action still uses file_pattern as the input and passes it as argv[5] to the entrypoint

@dctrwatson dctrwatson merged commit b617967 into main Aug 31, 2023
3 checks passed
@dctrwatson dctrwatson deleted the jw-multi-patterns branch August 31, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemiller joemiller joemiller left review comments

@emitamago emitamago emitamago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dctrwatson @joemiller @emitamago