Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.json #669

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update config.json #669

wants to merge 1 commit into from

Conversation

Danmark
Copy link

@Danmark Danmark commented Mar 3, 2025

Fix broken links

@frouioui
Copy link
Member

frouioui commented Mar 3, 2025

Hi @Danmark, the DCO check is failing. Do you mind fixing it?

https://github.com/planetscale/vitess-operator/pull/669/checks?check_run_id=38087049321

To add your Signed-off-by line to every commit in this branch:
Ensure you have a local copy of your branch by checking out the pull request locally via command line.

In your local branch, run: git rebase HEAD~1 --signoff

Force push your changes to overwrite the branch: git push --force-with-lease origin patch-1

@Danmark
Copy link
Author

Danmark commented Mar 3, 2025

Hi @Danmark, the DCO check is failing. Do you mind fixing it?

Yeah, I'll fix that.
I created the commit from the github web gui and I don't think it's supported there.

@Danmark
Copy link
Author

Danmark commented Mar 3, 2025

I have updated the PR according to your comments

@frouioui
Copy link
Member

frouioui commented Mar 3, 2025

https://github.com/planetscale/vitess-operator/actions/runs/13639862753/job/38127627553?pr=669 is failing, you will have to re-generate the api documentation (make generate)

Signed-off-by: Viktor Fogelberg <viktor.fogelberg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants