Fix overflow check

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
planetscale · Jan 29, 2025 · 829caf0 · 829caf0
1 parent 9e8ba03
commit 829caf0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/go/vt/vtctl/grpcvtctldserver/server.go b/go/vt/vtctl/grpcvtctldserver/server.go
@@ -1510,15 +1510,15 @@ func (s *VtctldServer) GetBackups(ctx context.Context, req *vtctldatapb.GetBacku
 
 	totalBackups := len(bhs)
 	if req.Limit > 0 {
-		if req.Limit > math.MaxInt {
+		if int(req.Limit) < 0 {
 			return nil, fmt.Errorf("limit %v exceeds maximum allowed value %v", req.DetailedLimit, math.MaxInt)
 		}
 		totalBackups = int(req.Limit)
 	}
 
 	totalDetailedBackups := len(bhs)
 	if req.DetailedLimit > 0 {
-		if req.DetailedLimit > math.MaxInt {
+		if int(req.DetailedLimit) < 0 {
 			return nil, fmt.Errorf("detailed_limit %v exceeds maximum allowed value %v", req.DetailedLimit, math.MaxInt)
 		}
 		totalDetailedBackups = int(req.DetailedLimit)