Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to include a build tag #122

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Commits on Dec 12, 2023

  1. Add ability to include a build tag

    This enables conditional compiling. This is particularly useful for
    shared protobufs for common APIs, where not all consumers have the same
    preferences around build size vs benefits of vtprotobuf. This allows the
    consumer of the library to chose whether vtprotobuf is used, rather than
    only the producer of the library.
    
    Additionally, it provides guidance to use `vtprotobuf` as the tag. The
    hope is that if multiple libraries do this, a user can just set that tag
    instead of `-tags=envoy_vt,enable_vtprotobuf_prometheus,vtproto_k8s` or
    something like that.
    
    See envoyproxy/envoy#31172, where this will be
    utilized (I think).
    howardjohn committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    c64fedf View commit details
    Browse the repository at this point in the history