Miscellaneous cleanup #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's make sure our naming is consistent. This is how it is written on the ESLint docs site.
Having the prefix makes it easier to quickly tell which commits were generated. Has been helpful in local dev when generating multiple test commits and needing to squash them down before pushing them up to Github.
ESLint will return exit code 2 if something completely breaks during parsing. Let's make sure that's exposed if we're looking for it.
danielma
approved these changes
Oct 8, 2024
molawson
approved these changes
Oct 9, 2024
Because the current file is blank, it was not causing the parsing issues we are seeing with v1.0.0 and non-js files
Without this manual filtering, ESLint will attempt to lint files that should be ignored (like ruby files). ESLint v9 has the `files` option in the flat config, and earlier versions have the `--ext` CLI flag. Let's aim for maximum compatibility and just ignore the files that don't end in the extensions we want.
fix: Use extensions input to filter files passed to ESLint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled these out of an upcoming branch for a bug fix as they weren't directly related to the problem at hand.