-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update goal settings design #5886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
@aerosol I used the Prima dropdown component that you used on CleanShot.2025-11-14.at.13.02.12.mp4 |
6ffea4a to
c67eefe
Compare
I'm not sure what's at fault yet, but the prima button element is losing its event listener on successful goal submission. Could be related either to pre-existing modal complexity or some hooks lifecycle, e.g. prima dropdown missing |
|
@aerosol agree with your analysis and solution. I've merged plausible/prima#17 and published a new version of prima |
ukutaht
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Looks good to me
- Replace the `Add goal` button in goal settings with a dropdown button to directly select the goal type. This way, a modal opens with the correct form for the selected goal type. The tabs in the modal have been removed. - Add a new `pill` component to show the goal type in the table in a more distinct way. The `settings_badge` component is replaced with the `pill` component. The `pill` component that was used in `plan_box.ex` is renamed to `highlight_pill`. - Replaced `Belongs to funnel` text with a funnel icon in the goal settings list. - Some small tweaks like increasing the search bar width, the padding of the table cells, and adding a header to the goal settings list.
This reverts commit 024b34a.
… fix" This reverts commit a6eabb7.
1ee5af3 to
946ae50
Compare
aerosol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Changes
Add goalbutton in goal settings with a dropdown button to directly select the goal type. This way, a modal opens with the correct form for the selected goal type. The tabs in the modal have been removed.pillcomponent to show the goal type in the table in a more distinct way. Thesettings_badgecomponent is replaced with thepillcomponent. Thepillcomponent that was used inplan_box.exis renamed tohighlight_pill.Belongs to funneltext with a funnel icon in the goal settings list.Tests
Dark mode