Skip to content

Fix Safari bug where + Add another step button wasn't hidden properly #5897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
Merged

Fix Safari bug where + Add another step button wasn't hidden properly #5897

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3eaa960
Fix Safari bug where `+ Add another step` button wasn't hidden properly
sanne-san Nov 20, 2025
702c9e2
Increase spacing between add step button and conversion rate when bot…
sanne-san Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions extra/lib/plausible_web/live/funnel_settings/form.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ defmodule PlausibleWeb.Live.FunnelSettings.Form do
Funnel steps
</.label>

<div :for={step_idx <- @step_ids} class="flex mb-3 mt-3">
<div :for={step_idx <- @step_ids} class="flex my-3">
<div class="w-2/5 flex-1">
<.live_component
selected={find_preselected(@funnel, @funnel_modified?, step_idx)}
Expand Down Expand Up @@ -117,13 +117,12 @@ defmodule PlausibleWeb.Live.FunnelSettings.Form do
</div>
</div>

<.add_step_button :if={
length(@step_ids) < Funnel.max_steps() and
map_size(@selections_made) < length(@goals)
} />

<div class="mt-6">
<p id="funnel-eval" class="text-gray-500 dark:text-gray-400 text-sm mt-2 mb-2">
<div class="flex flex-col gap-y-4 mt-6">
<.add_step_button :if={
length(@step_ids) < Funnel.max_steps() and
map_size(@selections_made) < length(@goals)
} />
<p id="funnel-eval" class="text-gray-800 dark:text-gray-200 text-sm">
<%= if @evaluation_result do %>
Last month conversion rate: <strong><%= List.last(@evaluation_result.steps).conversion_rate %></strong>%
<% end %>
Expand Down Expand Up @@ -179,7 +178,7 @@ defmodule PlausibleWeb.Live.FunnelSettings.Form do

def add_step_button(assigns) do
~H"""
<a class="underline text-indigo-500 text-sm cursor-pointer mt-6" phx-click="add-step">
<a class="text-indigo-500 text-sm font-medium cursor-pointer" phx-click="add-step">
+ Add another step
</a>
"""
Expand Down
Loading