Export fix #406
Merged
Export fix #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
approved these changes
Feb 16, 2025
|
Wouldn't it be better to report warnings/errors on load/import and then give option to fix? |
Yes would be good to add this too. In some cases values like -Infinity might actually be a valid value, for example for scale. But also we support blind PLY data which user can attach and we pass through unchanged. We will never want these values in a compressed.ply though, under no circumstance. So I think this step is still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the compressed export (and publish) to, by default:
This is done because we are seeing scenes published which contain a large numbers of invalid gaussian data (in some cases nearly half the scene). These gaussians don't render, but take storage and download space and slow down rendering, significantly in some cases.