Skip to content

Writer: ensure file name is not empty #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisnovakovic merged 2 commits into from
Oct 8, 2025
Merged

Writer: ensure file name is not empty #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa2586f
Writer: ensure file name is not empty
chrisnovakovic Oct 8, 2025
2c23709
Fix broken test
chrisnovakovic Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,10 @@ func (aw *Writer) WriteHeader(hdr *Header) error {
header := make([]byte, HEADER_BYTE_SIZE)
s := slicer(header)

if len(hdr.Name) == 0 {
return errors.New("ar: empty file name")
}

switch aw.variant {
case GNU:
// "/" is always appended to GNU-variant file names, which means that any file names over 15 bytes
Expand Down
1 change: 1 addition & 0 deletions writer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ func TestWriteTooLong(t *testing.T) {
body := "Hello world!\n"

hdr := new(Header)
hdr.Name = "hello.txt"
hdr.Size = 1

var buf bytes.Buffer
Expand Down