Reader: fill the buffer passed to Read#19
Merged
chrisnovakovic merged 1 commit intoplease-build:masterfrom Oct 8, 2025
Merged
Conversation
toastwaffle
approved these changes
Oct 8, 2025
chrisnovakovic
force-pushed
the
reader-read-full-string-table
branch
from
d6d665c to
9c95a99
Compare
`bufio.Reader.Read(p)` may read fewer than `len(p)` bytes from the underlying `io.Reader` into `p`. When it does, archive members appear artificially truncated; when this happens to the string table, it leads to red herring errors (e.g. missing entries, missing trailing newlines). After capping `len(p)` to the remaining number of bytes to be read from the current member's data section, ensure that exactly `len(p)` bytes are read from the underlying `io.Reader` when reading the string table.
chrisnovakovic
force-pushed
the
reader-read-full-string-table
branch
from
9c95a99 to
2867264
Compare
chrisnovakovic
changed the title
Read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bufio.Reader.Read(p)may read fewer thanlen(p)bytes from the underlyingio.Readerintop. When it does, archive members appear artificially truncated; when this happens to the string table, it leads to red herring errors (e.g. missing entries, missing trailing newlines).After capping
len(p)to the remaining number of bytes to be read from the current member's data section, ensure that exactlylen(p)bytes are read from the underlyingio.Readerwhen reading the string table.