Skip to content

Writer: don't write a file mode for the string table #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisnovakovic merged 1 commit into from
Oct 8, 2025
Merged

Writer: don't write a file mode for the string table #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ func (aw *Writer) WriteStringTable(filenames []string) error {
return nil
}
// need at least one long filename
if err := aw.WriteHeader(&Header{Name: "//", Mode: 0420, Size: int64(len(data))}); err != nil {
if err := aw.WriteHeader(&Header{Name: "//", Size: int64(len(data))}); err != nil {
return err
}
_, err := io.Copy(aw, bytes.NewReader(data))
Expand Down Expand Up @@ -256,7 +256,13 @@ func (aw *Writer) WriteHeader(hdr *Header) error {
aw.numeric(s.next(12), hdr.ModTime.Unix())
aw.numeric(s.next(6), int64(hdr.Uid))
aw.numeric(s.next(6), int64(hdr.Gid))
aw.octal(s.next(8), hdr.Mode)
// Only headers representing real files require file mode values - write an empty file mode field
// for the string table in GNU-variant archives.
if aw.variant == GNU && hdr.Name == "//" {
aw.string(s.next(8), "")
} else {
aw.octal(s.next(8), hdr.Mode)
}
aw.numeric(s.next(10), hdr.Size)
aw.string(s.next(2), "`\n")

Expand Down