ar: report error provenance#32
Merged
chrisnovakovic merged 1 commit intoplease-build:masterfrom Oct 8, 2025
Merged
Conversation
Right now, any error that occurs in the `ar` module is reported as simply ``` CRITICAL: Error combining archives: <error> ``` Given how much error handling happens in the `ar` module, this makes it hard to identify the precise reason for the error. Wrap errors inside more descriptive errors before passing them up to `main`.
toastwaffle
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, any error that occurs in the
armodule is reported as simplyGiven how much error handling happens in the
armodule, this makes it hard to identify the precise reason for the error. Wrap errors inside more descriptive errors before passing them up tomain.