You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hmmmm. Seeing some odd behaviour with go_repo where it doesn't always seem to recompile things (although I think it should since the libraries clearly seem to change with the config value)
Hmmmm. Seeing some odd behaviour with go_repo where it doesn't always seem to recompile things (although I think it should since the libraries clearly seem to change with the config value)
Oh really? Was it the go_librarys in the subrepos that weren't re-building? I haven't noticed anything like that... do you think it might be something to do with the config option not being inherited?
Hmmmm. Seeing some odd behaviour with go_repo where it doesn't always seem to recompile things (although I think it should since the libraries clearly seem to change with the config value)
Oh really? Was it the go_librarys in the subrepos that weren't re-building? I haven't noticed anything like that... do you think it might be something to do with the config option not being inherited?
I was getting some error about ABI mismatching because this was different. It seemed like it must be something not inhering somewhere, or something along those lines, but didn't get to the bottom of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a config setting allowing overriding the AMD64 target.
Have tested flipping back and forth between v1 and v3 and it seems fine (once I added the env var to everything)