Skip to content

Cgo fixes #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
izissise wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Cgo fixes #169

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d81d14
Add _module parameter generated by please_go
izissise Oct 26, 2023
3d15272
Remove -Wno-error, include PKG_DIR
izissise Oct 26, 2023
4bbe9f8
Pass _module to go_library
izissise Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions build_defs/cgo.build_defs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ subinclude("///go//build_defs:go", "///cc//build_defs:c")

def cgo_library(name:str, srcs:list=[], resources:list=None, go_srcs:list=[], c_srcs:list=[], hdrs:list=[],
package:str=None, compiler_flags:list&cflags=[], linker_flags:list&ldflags=[], pkg_config:list=[],
subdir:str='', deps:list=[], visibility:list=None, test_only:bool&testonly=False, import_path:str=''):
subdir:str='', deps:list=[], visibility:list=None, test_only:bool&testonly=False, _module:str='', import_path:str=''):
"""Generates a Go library which can be reused by other rules.

Note that by its nature this is something of a hybrid of Go and C rules. It can depend
Expand Down Expand Up @@ -97,7 +97,7 @@ def cgo_library(name:str, srcs:list=[], resources:list=None, go_srcs:list=[], c_
srcs = [cgo_rule + '|c'] + c_srcs,
hdrs = [cgo_rule + '|h'] + hdrs,
compiler_flags = compiler_flags + [
'-Wno-error',
'-I', '"$PKG_DIR"',
'-Wno-unused-parameter', # Generated code doesn't compile clean
],
pkg_config_libs = pkg_config,
Expand All @@ -113,6 +113,7 @@ def cgo_library(name:str, srcs:list=[], resources:list=None, go_srcs:list=[], c_
deps = deps,
_generate_import_config=False,
import_path=import_path,
_module = _module,
)

output = package if package else name
Expand Down