allow us to override srcs in config using go tempate with the build rule#112
Open
goddenrich wants to merge 1 commit intoplease-build:masterfrom
Open
allow us to override srcs in config using go tempate with the build rule#112goddenrich wants to merge 1 commit intoplease-build:masterfrom
goddenrich wants to merge 1 commit intoplease-build:masterfrom
Conversation
Tatskaari
approved these changes
Jun 27, 2024
Collaborator
Tatskaari
left a comment
There was a problem hiding this comment.
LGTM though we should update the example to explain how/when to use this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potential approch to being able to deal with some more unusual build defs which generate go related targets. eg it allows us to define a srcs argument which the underlying build def uses when inputting to a known type. One example is
and this allows us to define in config something which will make the srcs and therefore deps evaluate correctly