Add support for ignoring modules when syncing#143
Merged
toastwaffle merged 2 commits intoplease-build:masterfrom Aug 5, 2025
Merged
Add support for ignoring modules when syncing#143toastwaffle merged 2 commits intoplease-build:masterfrom
toastwaffle merged 2 commits intoplease-build:masterfrom
Conversation
SpangleLabs
approved these changes
Aug 5, 2025
Contributor
Author
|
golangci-lint is once again toast, so I am just going to forcibly land this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go mod tidyis a little overzealous with pulling in transitive dependencies, even when the bits of a direct dependency that we build with Please don't actually depend on the transitive dependency. As such, this allows specifying Go modules which will be present in thego.modfile (becausego mod tidyputs them there), but will not be present in theBUILDfile