feat: support overriding module-dir#240
Merged
toastwaffle merged 2 commits intoplease-build:masterfrom Apr 25, 2025
Merged
Conversation
`python_binary`, `python_test` and `python_wheel` all currently only support using the repository-wide module-dir which forces us to share the same set of python dependencies for every binary. This commit allows overriding this so we can independently version dependencies.
Contributor
|
Want to bump the plugin version so this gets released? |
toastwaffle
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 We'd like to be able to add tools available on PyPi and manage their dependencies separately from the rest of our codebase (e.g. semgrep depends on a few modules that we use in the codebase but are incompatibly versioned).
At the moment, it appears we're constrained by the
ModuleDirparameter to this plugin where we can only have one repository-wide directory for Python modules.This PR makes this configurable per
python_binary,python_testandpython_wheelwhich enables us to do things like this: