CI: separate tools and plugin release steps#248
Merged
chrisnovakovic merged 2 commits intoplease-build:masterfrom Oct 13, 2025
Merged
CI: separate tools and plugin release steps#248chrisnovakovic merged 2 commits intoplease-build:masterfrom
chrisnovakovic merged 2 commits intoplease-build:masterfrom
Conversation
Currently, tools releases (which include please_pex) are blocked if the tests fail when built by the stable please_pex release, which prevents new versions of please_pex from being released in the event that external factors (e.g. changes on the CI platform) cause please_pex to stop working. Break this cyclic dependency by only making tools releases contingent on the tests passing when built by the in-repo version of please_pex, and only make plugin releases contingent on the tests passing when built by the version of please_pex downloaded by `//tools:please_pex`. This allows us to fix problems with please_pex, get a new version released, and use that version in the plugin without having to ignore CI test failures at any stage.
chrisnovakovic
commented
Oct 13, 2025
Contributor
Author
There was a problem hiding this comment.
This test is obsolete now that we're no longer relying on actions/setup-python to put python3 in our PATH - plugin.python.defaultinterpreter is now being set to the absolute path to the interpreter installed by the action, so we know for sure which interpreter we're using.
toastwaffle
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, tools releases (which include please_pex) are blocked if the tests fail when built by the stable please_pex release, which prevents new versions of please_pex from being released in the event that external factors (e.g. changes on the CI platform) cause please_pex to stop working.
Break this cyclic dependency by only making tools releases contingent on the tests passing when built by the in-repo version of please_pex, and only make plugin releases contingent on the tests passing when built by the version of please_pex downloaded by
//tools:please_pex. This allows us to fix problems with please_pex, get a new version released, and use that version in the plugin without having to temporarily disable any tests in the workflow.