Improve background job stream handling #2235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actions-bot-pl
previously approved these changes
Oct 11, 2025
Remove job control handling from subprocess observation function.
plengauer
force-pushed
the
2230-background-jobs-in-github-actions-will-indefinitely-stall-the-step-in-case-the-streams-are-not-closed
branch
from
ae4aeab to
16ff446
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the handling of background job streams to prevent process hangs when child processes inherit stdout/stderr and don't terminate with their parent. The changes introduce timeout-based waiting mechanisms and restructure the GitHub Actions logging pipeline to use named pipes with explicit cleanup.
Key changes:
- Added
_otel_wait_for_process_with_timeout()utility function to wait for processes with a configurable timeout - Refactored GitHub Actions step logging to use a dual-pipe architecture with timeout-based cleanup
- Reduced various timeout values to minimize potential hang durations
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/usr/share/opentelemetry_shell/api.sh | Adds new timeout-based process waiting utility function |
| src/usr/share/opentelemetry_shell/api.observe.subprocesses.sh | Removes job control logic and adds output suppression to background process |
| src/usr/share/opentelemetry_shell/api.observe.pipes.sh | Implements timeout-based waiting for pipe observer processes and consolidates cleanup |
| src/usr/share/opentelemetry_shell/api.observe.logs.sh | Removes job control logic, adds output suppression, and removes stderr_pid wait |
| actions/instrument/job/inject_and_init.sh | Reduces timeout from 60s to 5s for Python process cleanup |
| actions/instrument/job/decorate_action.sh | Restructures logging using dual named pipes with timeout-based cleanup |
| .github/workflows/test_github.yml | Adds test case for background job handling |
auto-merge was automatically disabled
November 9, 2025 20:06
Pull request was converted to draft
moflwi
approved these changes
Nov 10, 2025
plengauer
deleted the
2230-background-jobs-in-github-actions-will-indefinitely-stall-the-step-in-case-the-streams-are-not-closed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.