Introduce a function to extract all includes from bind configuration file #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SandakovMM
force-pushed
the
handle-all-included-files
branch
2 times, most recently
from
2408550
to
60a2846
Compare
vizovitin
requested changes
Oct 2, 2024
|
We need to support chroot because we store all named configurations in a chroot environment for named (/var/named/chroot/) |
vizovitin
requested changes
Oct 3, 2024
SandakovMM
force-pushed
the
handle-all-included-files
branch
from
e27f12f
to
b48f93b
Compare
vizovitin
previously approved these changes
Oct 3, 2024
pleskdistup/common/src/dns.py
Outdated
| includes: typing.List[str] = [] | ||
|
|
||
| def get_all_includes_from_bind_config(config_file: str, chroot_dir: str = "") -> List[str]: | ||
| includes: List[str] = [] | ||
|
|
||
| if config_file.startswith("/"): |
There was a problem hiding this comment.
Nitpick: there's os.path.isabs() for that.
…file It should support chroot directories because we use chroot environment for bind configurations in plesk. Also we should not encounter relative paths in include directives because bind handles they in a preatty specific way (starting from the directory bind was started)
SandakovMM
force-pushed
the
handle-all-included-files
branch
from
b48f93b
to
b9df963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.