UDP: Ensure propagation of control message to pool.Message

[jkralik]

This commit enhances the UDP functionality, ensuring proper dissemination of control messages to pool.Message for improved network coordination and responsiveness

[codecov-commenter]

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (d63d5c8) 72.52% compared to head (7e6b2bb) 73.85%.

Files	Patch %	Lines
net/connUDP.go	77.83%	40 Missing and 5 partials ⚠️
message/pool/message.go	80.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
+ Coverage   72.52%   73.85%   +1.32%     
==========================================
  Files          70       71       +1     
  Lines        5504     5729     +225     
==========================================
+ Hits         3992     4231     +239     
+ Misses       1115     1112       -3     
+ Partials      397      386      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[HRogge]

Source-Address is also valid when receiving packet, same address as the "remote" parameter you get from the read

[jkralik]

According to doc the https://pkg.go.dev/golang.org/x/net@v0.18.0/ipv4#ControlMessage it seems that Src cannot be set for write.

[HRogge]

doc says "specifying only" for source (as in "write only).

but I am quite sure (just tested it on Debian) that you ALSO get the source set when receiving.

[HRogge]

Interface-Index 0 is defined as "any interface", so I think the "must be 1<=" part of the comment can be removed.

[jkralik]

Fixed, thx :)

[HRogge]

I just checked out the latest commit of this branch and I successfully got src/dst-IP address and Interface Index. I am looking forward to see this merged.

[HRogge]

Just re-tested with the current commit, still works fine.

[jkralik]

@HRogge Pls this is a final state. Could you check if it works as it is expected ?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

82.1% Coverage
0.0% Duplication

[HRogge]

@HRogge Pls this is a final state. Could you check if it works as it is expected ?

It seems that multicast transmission is broken... not sure why, still trying to understand. I get neither a compiler nor a runtime error when using WriteMulticast() on net.UDPConn

[HRogge]

I also get a broken Date for the current commit when I look at it with 'git log':

commit 7e6b2bbd34f0051d0ff09d06af2d453450a30706 (HEAD -> jkralik/feature/udp-propagate-interface, github-upstream/jkralik/feature/udp-propagate-interface)
Author: Jozef Kralik <jojo.lwin@gmail.com>
Date:   Wed May 10 15:11:10 2023 +0000

    Update UDP: Ensure propagation of control message to pool.Message
    
    This commit enhances the UDP functionality, ensuring proper dissemination
    of control messages to pool.Message for improved network coordination
    and responsiveness

[HRogge]

@HRogge Pls this is a final state. Could you check if it works as it is expected ?

It seems that multicast transmission is broken... not sure why, still trying to understand. I get neither a compiler nor a runtime error when using WriteMulticast() on net.UDPConn

It seems my multicast now ignores the specified interface and goes along the default route (into my local management interface).

[HRogge]

@HRogge Pls this is a final state. Could you check if it works as it is expected ?

It seems that multicast transmission is broken... not sure why, still trying to understand. I get neither a compiler nor a runtime error when using WriteMulticast() on net.UDPConn

It seems my multicast now ignores the specified interface and goes along the default route (into my local management interface).

facepalm okay, got the problem resolved... stupidity on my side.

[HRogge]

Code works fine with the multicast application I have been using for testing. Looking forward to see it merged.