Detect WebAPI2 RouteAttribute and use its route name if found #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #30
This isn't a complete solution - more work required to tidy up, add tests, etc. However I wanted to discuss the approach before going further.
Currently Hyprlinkr doesn't require WebAPI2 / .NET 4.5. Hence we can't use the WebAPI2 RouteAttribute directly. There's a workaround - I've tested that this pull request does the job. But it's not terribly nice having to use reflection for everything.
Options I can see:
Any thoughts on how comfortable you'd be with something based on this pull request? If not then I suspect option 2 would be the way to go.