Web API v2.0 compatibility #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match Json.Net package version in web.config
|
Great observation! This pull request is an application of Postel's law, so I'm all for it 👍 Thank you for your contribution! It's now live as Hyprlinkr 2.0.1. |
|
Thank you, much appreciated ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much related to issue #30 and pull #36
Hyprlinkr 2.0.0 requires WebApi 2.2 (package version >= 5.2.3). Web API v2.0 (packages v5.0.0+), however, already supported attribute routing.
I looked through pull #36 and couldn't see anything that required v5.2.3 (rather than 5.0.0). I tried locally, ran the tests and ran my own code against it and everything seemed to work fine when referencing 5.0.0. I get that this might be a bit unusual but is this something you would consider merging ? There are no new features, so I am well aware that this is pretty boring but I really like the lib and would love to use it (I am using mono and compatibility with 5.2.3 isn't quite there yet so I cannot upgrade my version of the Web API to 5.2.3).
This is my first ever pull request so please let me know if I didn't do this properly. Thank you !