Deleting import zope.interface implements #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilbacardit26
requested review from
bloodbare,
vangheem and
masipcat
as code owners
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1189 +/- ##
========================================
- Coverage 94.6% 94.6% -0.0%
========================================
Files 377 377
Lines 32771 32770 -1
========================================
- Hits 30992 30991 -1
Misses 1779 1779
|
|
It's a vanity import to be able to use the I don't think it's a good idea to hard pin a version -- it can be annoying for consumers |
nilbacardit26
force-pushed
the
pinning-implements
branch
from
5d4e315
to
ef0ae70
Compare
nilbacardit26
force-pushed
the
pinning-implements
branch
from
ef0ae70
to
4a88211
Compare
|
@vangheem done, I will run the tests I have in another project just to be sure this import is not breaking anything |
vangheem
approved these changes
Nov 16, 2023
masipcat
approved these changes
Nov 16, 2023
|
@nilbacardit26 everything look good? We can merge then |
|
@vangheem yes, I am not authorized to merge, feel free to do it |
nilbacardit26
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time I install guillotina as a dependency I encounter this error:
Error importing plugin "guillotina.tests.fixtures": cannot import name 'implements' from 'zope.interface. implements is not there anymore in version 6.1 'zope.interface
I do not know what this line does, implements is not used anywhere. I passed all the test without this line. Some of you know why is it there?
https://github.com/plone/guillotina/blob/master/guillotina/component/interfaces.py#L19