apply published state for migrations of broken comments #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For migrations of comments without a valid old_status, apply the 'published' state.
i have a situation, where in line 119 of plone.app.event.browser.migration returns None:
old_status = workflow.getStatusOf(oldchain, reply)
since i had the one_state_publication workflow for discussion items applied, i solved the issue by applying the published state to those comments.
i don't know if this is acceptable as default behavior, so please review it.
if you need more information obout the comments in question, i'm happy to help.
this is the traceback i got before my change: