Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unwrap search_base in portlets #187

Merged
merged 1 commit into from
May 31, 2015
Merged

unwrap search_base in portlets #187

merged 1 commit into from
May 31, 2015

Conversation

thet
Copy link
Member

@thet thet commented May 26, 2015

Unwrap search_base for portlets, as it might be wrapped by the portlet renderer class. Fixes an error with getting the events to display.

…t renderer class. Fixes an error with getting the events to display.
@jensens
Copy link
Member

jensens commented May 27, 2015

test runs here http://jenkins.plone.org/job/pull-request/163/

  • ok
  • fails

@thet
Copy link
Member Author

thet commented May 27, 2015

I actually don't really understand the issue, but it suddenly appeared where I used the event portlet with a Collection as search_base. However, this fixes it :)

@jensens
Copy link
Member

jensens commented May 27, 2015

Sometimes it happens, that aquisition is wrapped twice. I had this in the context of portlets several times, but also at other places. Usally you want only the inner (first, original) aquisition and so aq_inner is what you want. So this is perfectly fine afaict.

@jensens
Copy link
Member

jensens commented May 27, 2015

@thet targets master branch on 4.3 as well?

@thet
Copy link
Member Author

thet commented May 27, 2015

Yes, also 4.3

thet added a commit that referenced this pull request May 31, 2015
@thet thet merged commit 6411887 into master May 31, 2015
@thet thet deleted the thet-unwrap-searchbase branch June 10, 2015 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants