Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traverse to theme resources from the portal #232

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

pbauer
Copy link
Member

@pbauer pbauer commented Dec 25, 2023

Fix broken theme when rendering accessible content contained in an inaccessible navigation-root.
Fixes #142

…ndering accessible content contained in an inaccessible navigation-root. Fixes #142
@mister-roboto
Copy link

@pbauer thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@pbauer
Copy link
Member Author

pbauer commented Dec 25, 2023

@jenkins-plone-org please run jobs

Copy link

@yurj yurj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

We should add some docs to explain how theme resources traversing works.

@MrTango
Copy link
Contributor

MrTango commented Jan 5, 2024

This might make problems for sub sites like collective.lineage, did you test that?

@pbauer
Copy link
Member Author

pbauer commented Jan 6, 2024

I don't think this is a issue since subsites that use a different theme with (using lineage.themeselection) should still have normal theme-files that are traversable from the site-root. I've never had that use-case and did not test it though.

@pbauer pbauer merged commit 4c87b37 into master Jan 12, 2024
6 checks passed
@pbauer pbauer deleted the fix_theme_in_inaccessible_navroot branch January 12, 2024 09:15
@mauritsvanrees
Copy link
Member

This causes a regression: #236

I have a proposed fix here: #237
Please check if your use case still works with that code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug (theme not applied) if we have a public section in a private Plone site
6 participants