-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traverse to theme resources from the portal #232
Conversation
…ndering accessible content contained in an inaccessible navigation-root. Fixes #142
@pbauer thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
We should add some docs to explain how theme resources traversing works.
This might make problems for sub sites like collective.lineage, did you test that? |
I don't think this is a issue since subsites that use a different theme with (using lineage.themeselection) should still have normal theme-files that are traversable from the site-root. I've never had that use-case and did not test it though. |
Fix broken theme when rendering accessible content contained in an inaccessible navigation-root.
Fixes #142