-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Mockup to version 4, patternslib to version 3 and jQuery to 3.5.1. #102
Conversation
@thet thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
With this simple comment all the jobs will be started automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
Is this meant for Plone 5.2? I can't really tell whether that is wise and what it could possibly break. I may want to do a Plone 5.2.3 release in one or two weeks, and this sounds possibly dangerous, if only because of the massive amounts of files changed. But maybe they are all tiny, safe changes. |
At least this should made available for Plone 5.x. I think it's even safe for Plone 5.2. It's basically an upgrade to jQuery 3 and patternslib 3. Addons which use really outdated API calls from jQuery might break, though. |
I agree, 5000+ changed files are a lot... |
Implication for: |
@jenkins-plone-org please run jobs |
I am also largely sceptical if this should go into 5.2.x ... I am fine to branch away (I am pretty sure some of my sites will break). |
We could talk about doing a 5.3. Larger changes such as this, and also bootstrap 4, might be okay there. Work on supporting Plone 5.2 would quickly stop then. |
I dont think bootstrap 4 should go there either, this is a bigger change. I would really like to see 5.x frozen feature wise and only getting bugfixes. I am sure it would upset a whole bunch of people if we now start doing a 5.3 or not supporting 5.2.x any more. Lets focus on 6.0 and keep 5.2 as the stable beast with Python 2.7 support. |
@jensens @mauritsvanrees this is not about Bootstrap 4 |
@jensens - the changes in "Mockup 4" (jQuery 3) should go into Plone 5.x IMO. Otherwise they won't land anywhere. |
Barceloneta with Bootstrap 4 targets Plone 6, I won't invest any time for Plone 5.2 and absolutely not for Python 2. |
@thet I would support a |
@jensens @agitator the plone.staticresources branch which I plan for Plone 6 will not be compatible with 5.2 because it will not make use of RequireJS and almost no resource registry. Later today I will look into the reason why there are 5000+ file changes. Probably it's due to the updated Patternslib library which uses many external libraries (masonry, tippy, photoswipe, slick, anythingslider, etc) which we are not using but have to install due to the dependency chain. The Jenkins failures are due to the usage of jQuery.size() which was deprecated with jQuery 1.8, 8 years ago. A fix is provided here: plone/Products.CMFPlone#3195 + plone/Products.CMFPlone#3196 @MrTango what's your opinion here? We were discussing this issue since some time now... |
@jenkins-plone-org please run jobs |
Regardless of in which version this ends up: a jQuery update is long overdue, so thanks for working on that! |
I agree with @mauritsvanrees - this is awesome work and long overdue - thanks so much! Also, I think its save to merge in master anyway. Question is, to branch or not to branch from a point before the merge? And this is a question for both, the release and framework teams IMO. |
@mauritsvanrees @jensens tnx! As of the test failures I see that there are other places where the deprecated |
If the existing problems in core are fixed, it might be not a bad idea to go for a 5.3 with this important Jq-update. If we don't go for a 5.3, it would help if we have a working set of package version with this fixes, even if they don't belong to a Plone release. Who ever needs these fixes, can pin these version and use the newer versions in 5.2. So branching befor merging makes sence anyway. |
I think this is a good solution. |
So then we would keep things stable and compatible by default, but people who know what they are doing can install newer versions of @thet Does that work for you too? That does sound like there will be more work keeping branches working, back porting/forward porting. |
@jensens @mauritsvanrees @MrTango sounds good to me! |
@jenkins-plone-org please run jobs |
The @plone/framework-team is happy with this plan https://community.plone.org/t/fwt-meeting-minutes-2020-11-10/13086 |
I think we can close this. All effort is going into the es6 branch. |
Half a year ago, or with more people working on it, the situation may have been different. But now it makes sense to focus on Plone 6. |
People ask for an updated jQuery on Plone 5.2. |
No description provided.