Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to TinyMCE (builded) 4.9.11. #109

Closed
wants to merge 1 commit into from
Closed

Conversation

fredvd
Copy link
Member

@fredvd fredvd commented Nov 7, 2020

@mister-roboto
Copy link

@fredvd thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@fredvd
Copy link
Member Author

fredvd commented Nov 7, 2020

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Member

We should probably wait with this until after Plone 5.2.3 is released. This sounds like a change that we want to test in coredev for a while.

But: where are the changes? Did you forget to push something? Or is the diff on GitHub tricking me?

@fredvd
Copy link
Member Author

fredvd commented Feb 17, 2021

This went nowhere, creating a new PR

@fredvd fredvd closed this Feb 17, 2021
@fredvd fredvd deleted the fredvd-tinymce-4_9_11 branch February 17, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants