Skip to content

Define DEVELOP_DIST as -1 integer.#59

Merged
mauritsvanrees merged 2 commits intomainfrom
maurits-develop-dist-int
Nov 10, 2025
Merged

Define DEVELOP_DIST as -1 integer.#59
mauritsvanrees merged 2 commits intomainfrom
maurits-develop-dist-int

Conversation

@mauritsvanrees
Copy link
Member

That is how it is defined in setuptools/pkg_resources: https://github.com/pypa/setuptools/blob/v80.9.0/pkg_resources/__init__.py#L395

I added a print statement in our track_get_dist function in the line before this is actually used, but nothing got ever printed. So I may not know how to properly trigger this.

I don't notice anything going wrong with the current code, but anyway, this makes our definition match with that in pkg_resources, so should be good.

@jensens
Copy link
Member

jensens commented Nov 7, 2025

I am fine with it, just add an Entry to the change log and merge it.

@mauritsvanrees mauritsvanrees merged commit 32236d4 into main Nov 10, 2025
9 checks passed
@mauritsvanrees mauritsvanrees deleted the maurits-develop-dist-int branch November 10, 2025 19:49
@mauritsvanrees
Copy link
Member Author

Ah, when I created the PR I was looking for either a towncrier news snippets directory or a CHANGES.md version heading with 'unreleased' as date, and did not see this, so I did not add it. Done now, and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants