Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the filename which was to be updated in internationalization #937

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

GOGETASSB23
Copy link
Contributor

@GOGETASSB23 GOGETASSB23 commented Mar 20, 2025

In the internationalisation part of the Volto hands on training,we have to first translate the Plone release content type of our site. The file to be updated is PloneReleaseView.jsx , but the training documentation says the file to be updated is plonerelease.jsx , which we never created in past.

I corrected the file which should be updated-- PloneReleaseView.jsx (and not the non existent plonerelease.jsx)

This can cause confusion to a new developer, and he might create a plonerelease.jsx which technically was PloneReleaseView.jsx .


📚 Documentation preview 📚: https://plone-training--937.org.readthedocs.build/

…ation part of Volto-hands-on training

In the internationalisation part of the Volto hands on training,we have to first translate the Plone release content type of our site. 
The file to be updated is PloneReleaseView.jsx , but the training documentation says the file to be updated is plonerelease.jsx , which we never created in past.

I corrected the file which should be updated-- (PloneReleaseView.jsx ,and not the non existent plonerelease.jsx)

This can cause confusion to a new developer, and he might create a plonerelease.jsx which technically was PloneReleaseView.jsx .
@GOGETASSB23 GOGETASSB23 changed the title Corrected the filename which was to be updated in the internationaliz… Corrected the filename which was to be updated in internationalization Mar 20, 2025
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good catch. Merging.

@stevepiercy stevepiercy merged commit 7037d18 into plone:main Mar 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants