This repository has been archived by the owner on Apr 20, 2021. It is now read-only.
Hyphenate the arguments #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcbrand does this look OK? |
|
@cillianderoiste Perfect, thanks! |
| @@ -47,8 +47,8 @@ | |||
| var date = moment(dateStr, options.format, options.locale, options.strict); | |||
| if (options.fromNow == true) { | |||
| date = date.fromNow(); | |||
| } else if (options.outputFormat.length) { | |||
| date = date.format(options.outputFormat); | |||
| } else if (options.output.format.length) { | |||
There was a problem hiding this comment.
Should these be hyphenated, not dot separated?
There was a problem hiding this comment.
No, it's correct like that. The parser creates the options object like that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIUC this isn't being used anywhere, so I didn't add an alias for the older arguments. Please let me know if I should.