This repository has been archived by the owner on Apr 20, 2021. It is now read-only.
Match yeoman output #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 29, 2015 15:53
Now has .editorconfig and .jshintrc etc.
Merged
|
@jcbrand as you wrote the yeoman generator would you be able to please review this? |
| // If require.js is not available, you'll need to make sure that these | ||
| // global variables are available. | ||
| factory($, patterns.Base, patterns, patterns.Parser, patterns.logger); | ||
| } |
There was a problem hiding this comment.
moment needs to be passed in here, like so:
factory($, patterns.Base, patterns, patterns.Parser, patterns.logger, moment);
There was a problem hiding this comment.
I thought that might have been the case. I meant to ask but it slipped my mind.
|
hi @adrianwhite, looks good, just two small things I mentioned in inline comments. |
|
@jcbrand I've pushed a couple of commits as per your notes. |
|
Cheers! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tidies up the code to match that of the Yeoman generated pattern and updates the code to use Base.