Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test for DashDaq.jl + Readme #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Unit test for DashDaq.jl + Readme #3

wants to merge 2 commits into from

Conversation

efmanu
Copy link
Collaborator

@efmanu efmanu commented Jul 3, 2021

This PR is to add unit tests to DashDaq.jl
Also Readme file is modified

@efmanu efmanu requested a review from jdamiba July 3, 2021 16:52
jdamiba
jdamiba approved these changes Jul 4, 2021
View reviewed changes
Copy link
Contributor

@jdamiba jdamiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me! Great job with the unit tests, they are very clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdamiba jdamiba jdamiba approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efmanu @jdamiba