Skip to content

Commit

Permalink
Remove close_fds to avoid spooky window behavior
Browse files Browse the repository at this point in the history
  • Loading branch information
ayjayt committed Sep 28, 2024
1 parent 641d34a commit a5057ac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion devtools/chrome_wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def open_browser(to_chromium, from_chromium, stderr=None, env=None, loop=None, l
f"--remote-debugging-io-pipes={str(to_chromium_handle)},{str(from_chromium_handle)}"
]
if platform.system() == "Windows":
win_only = {"creationflags": subprocess.CREATE_NEW_PROCESS_GROUP, "close_fds":False}
win_only = {"creationflags": subprocess.CREATE_NEW_PROCESS_GROUP}
if not loop:
return subprocess.Popen(
cli,
Expand Down

0 comments on commit a5057ac

Please sign in to comment.