-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch simplejson to orjson #168
Conversation
👍 on my list for today |
@neyberson this isn't passing tests
This message is correct but the new parser is reading it as one message. It's a json message followed by a control message. This needs to be resolved. |
@neyberson the problem is that with package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failing tests
also @neyberson this is particularly an issue with windows which, on all other machines, the OS seems to fill and flush the buffer message per message but windows messages sometimes come in partially, sometimes grouped, etc |
This is paused- orjson is a better option fundamentally but also doesn't support some things we need (streams etc). At the same time, I think this is 100% necessary for the plolty ecosystem to address some other errors. |
We have a pull request for this one the local too, not sure, closing this one, orjson is nice but not workable until streaming + common invalid issues are addressed |
orjson
simplifies and solves some issues:So, just adding the option
OPT_SERIALIZE_NUMPY
in theorjson.dumps()
, avoid the issues with numpy and usingorjson
simplifies the code