Andrew/precommit #173
Closed
Andrew/precommit #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently on precommit branch because precommit is forcing us to update some versions in GHA and we need a better tool.
When we `choreo_get_chrome` CLI or `get_chrome|_sync()` without arguments, we will now use detected versions. We will also LOOK for this version of chrome before hand and use that if we find it.
Old headless mode wouldn't populate a default tag, but now there is always a default tab, so we have to change the tests."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may cause tests to fail- its not our fault, but this commit should also make the switch to UV and tox w/ a changetot he chromium download.... so lets get that done (IE combine the GHA download pr)