-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Andrew/refactor #178
Open
ayjayt
wants to merge
35
commits into
main
Choose a base branch
from
andrew/refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Andrew/refactor #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipe will eventually be one of two options (the other being websocket), and since we're currently writing a CLI+ENV var generator for chromium/chrome/edge (eventually supporting firefox), Pipe is now a bit better organized so that these other classes can detect it and better interpret it.
sys utils needs to be refactored before we can finish browser since sys utils will provide mechanisms to find chromium issue where BROWSER_PATH might now also be firefox but I suppose that just means you would have to specify firefox I think brave will work with this
_browsers/ interfaces have now changed a bit to 1. provide popen args 2. find their own path Plus we've exported a lot of needed symbols in various __init__.py's Plus organized and renamed some stuff among the tmpfiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively large refactor but each commit is well written in stages.
That said, intermediate stages (commits) don't function.
description
We start with creating browser specific classes that ONLY return the CLI and env vars for a specific brand.
This lets us split the stages:
securing the proper file descriptors.
This requires two other refactors:
First:
Pipe will be refactored to have a standard interface (although it wont necessarily be enforced)
Pipe will split out serializer so that other channel types (like WebSocket) can use it.
Second:
System utilities needs to better divide its concerns:
Then, the last refactor will be splitting browser into sync and async, where async will be composed with a broker class to separate the ideas of process control and async manage (sync doesnt really need a broker since sync can't do any sort of management anyway since it can't deal with the inherent asyncronicity of the process-process interaction).
After that, tests will be fixed since namespaces will have changed, even if expectations havent.
Documentation will then be included and built.
And we launch v1.0.0rc on testpypi.