Cc rebase plotly4.11 #2454
Draft
Cc rebase plotly4.11 #2454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0a909c8.
* New version of scales no longer 'spans the gamut' of a qualitative color palette * reduce Reduce() for merging lists use do.call() instead to avoid quadratic complexity of growing lists * ensure_one(): reduce noise if attrs are NULL ignore NULL values * ggplotly: fix Xaxis anchor if the last row incomplete attach X axis to the last non-empty row in a column * stylistic changes * validate new visual baselines * Doesn't seem like we need to handle yaxis being a factor and if we do, it likely needs a different fix * update shinytest baselines * ugh maintaining shinytest tests for htmlwidgets is a real pain * update sf baselines * go back to using ggplotly() to prepare the widget for shiny rendering * the extra call to plotly_build() forces more computation then necessary and fixes plotly#1569 * Generation of non-intercept data in hline/vline should respect coord_flip(), closes plotly#1519 * update news; fix typo * Account for new changes in ggplot2's internal API, fixes plotly#1561 * Break values of positional scales have moved from to * Text labels of positional scales have moved from to * sf graticule degree labels are now quoted? * include braces * gsub * moar braces * new sf baselines * update news * upgrade to plotly.js v1.49.0 * upgrade to plotly.js v1.49.2 * upgrade to plotly.js v1.49.4 * update baseline * update shinytest baseline * make a deep copy of x.layout.width/x.layout.height for use in the resize method, closes plotly#1553 * Wrap user-supplied expression in evalq(), closes plotly#1528 * Use shiny::installExprFunction to register debug hooks * Asynchronously register plot events * Revert "Merge pull request plotly#1539 from ropensci/renderWidgetPrep" This reverts commit d416cea, reversing changes made to d11bb5a. * no need to be making deep copies * Improvements to algorithm for attaching key attribute for shiny's event data, fixes plotly#1610 * Account for pointNumbers * Do nothing if we don't recognize the case * When pointNumber is a constant, relay it as such * handle the 3 cases separately * use idx instead of i * update news * Call setInputValue only if it's defined, closes plotly#1624 * Revert "Revert "Merge pull request plotly#1539 from ropensci/renderWidgetPrep"" This reverts commit 2856731. * pass along a quoted expr that calls func() * Revert "go back to using ggplotly() to prepare the widget for shiny rendering" This reverts commit a0fa68f. * update news * verify_webgl() shouldn't warn about types that are already gl, closes plotly#1569 * fix test * Do not create structure with NULL to remove warnings * Fix management of environments in renderPlotly(), fixes plotly#1639 Both assignment and evaluation of func() should happen in the local environment * Add test to prove plotly#1299 fix * proposed change to avoid peeking at 'grid' unit internals * improve previous commit * refactor Paul's unit type commits from plotly#1646 * Some CRAN builds don't have pandoc * plot_mapbox() shouldn't force a scattermapbox trace type, closes plotly#1608 * fix R CMD check notes * r-devel apparently doesn't yet have grid::unitType() * remove outdated travis config * Validate changes visual baselines due to changes in R3.6's new RNG method * Add support for new plotly_sunburstclick event, closes plotly#1648 * validate new shinytest baselines * update news * fix silly mistake from 3cbccfc * document * test expectation should account for changes in the default color palette on r-devel * improve the aforementioned test example and add a visual test * Ignore calculated aesthetics that match specified aesthestics After tidyverse/ggplot2@10fa0014, it's possible for calculated aes to exist for all default_aes * fix broken link raster2uri and improve the description * cran hyperlinks must be https * fix roxygen warning * In contrast to attr(x, unit), the new grid::unitType() function always return a vector the same length as it's input * bump to release version; submit to CRAN * Respect sf's plot12 graticule attribute when building axis ticks, fixes plotly#1673 * Remove missing values in ticktext/tickvals As discussed in tidyverse/ggplot2#3566 (comment), it's now possible for the ggplot2 labels/positions to contains missing values, and we should be able to simply ignore them * link to comment * remove outdated/bad test expectation...the visual baseline covers it * Don't assume sf geometry is always accessible via [['geometry']], fixes plotly#1659 * validate baselines * update news * update to plotly.js 1.52.2 * new baselines * Add image and treemap visual tests. Also, ensure treemap's stroke reflects the paper's bgcolor * Add Object.setPrototypeOf polyfill for shinytest and update shinytest json baseline * Add add_image() for easier rendering of image traces via raster objects * Bump version, update news, document, add unit test for add_image() * roxygen escapes % now * Only call locale_dependency() for locales not included with standard bundle, closes plotly#1686 * CRAN submission * plot_mapbox() should default to scattermapbox unless z is present, fixes plotly#1707 * add visual test for plotly#1674 * update poor test expectations that assume stringsAsFactors defaults to TRUE * bump version; update news * update visual tests * remove rnaturalearth dependency in tests Co-authored-by: Carson Sievert <cpsievert1@gmail.com> Co-authored-by: Alexey Stukalov <astukalov@gmail.com> Co-authored-by: Wim <wfjvdham@gmail.com> Co-authored-by: Paul Murrell <paul@stat.auckland.ac.nz>
* Fix bug in verify_attr. Closes issue plotly#1720. * Add test to check that ggplotly does not break discrete x-axis in facet panels with only one category. * Update tests/testthat/test-facet-axis.R Co-authored-by: Carson Sievert <cpsievert1@gmail.com> * Add news item. * Translate `\n` to `<br />` in fct labels, too (plotly#1700) * Translate `\n` to `<br />` in fct labels, too Before, this only worked for colums of type character. * add @salim-b as ctb * Add test for `translate_linebreaks()` * remove superfluous char conversion * change order of authors * replace forcats code with base R * add news item Co-authored-by: Stefan Moog <moogs@gmx.de> Co-authored-by: Carson Sievert <cpsievert1@gmail.com> Co-authored-by: Salim B <salim@posteo.de>
* Get ggplotly() playing nicely with thematic (plotly#1801) * Pull plotly's custom ggplot_build into a function and hook into thematic if relevant * add thematic to suggests and use it only when loaded * update shinytest tests * Go back to the assign() based approach * bust cache * CRAN version of crosstalk * add visual tests * update news Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
Use Plotly version 1.58
Merge branch 'master' of https://github.com/ropensci/plotly into ropensci-master # Conflicts: # DESCRIPTION # R/sysdata.rda # inst/docker/Dockerfile.vtest # inst/htmlwidgets/lib/plotlyjs/plotly-latest.min.js
Merge branch 'ropensci-master' # Conflicts: # R/plotly.R # inst/htmlwidgets/lib/plotlyjs/plotly-latest.min.js
RS-7135: re-setting plotly-latest to 1.58
Plotly 1.58 plus autoMargin minHeight patch
* Use latest bundle 2.35.2 * Turn off warning for barcornerradius * Add documentation * Only run standard tests * Remove github workflow * Remove travis CI config * Use same circle CI config as other flip packages * Replace with default config * Try to turn off all tests * Stop returning error * Turn off build
DPI-2832: Pack plotly in nix
* Initial commit * Remove prepush * Final line for plotly.yml * Re-add lib * Refactor * Create test * Specify rhtmlBuildUtils version * Remove preinstall script * Delete package-lock.json * Update documentation * Update documentation and remove library * Restore files * Restore file * Update build files
* Test callback * Update compiled files * Add rhtmlwidget-status attribute * wording change
* Candidate fix * Bump version
* Use latest bundle 2.35.2 * Turn off warning for barcornerradius * Add documentation * Only run standard tests * Remove github workflow * Remove travis CI config * Use same circle CI config as other flip packages * Replace with default config * Try to turn off all tests * Stop returning error * Turn off build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.